-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/master/pe 10914 add osx 109 upgrade #70
Issue/master/pe 10914 add osx 109 upgrade #70
Conversation
ec959de
to
414f2fe
Compare
Commit still says WIP. |
414f2fe
to
41be250
Compare
rebased, fixup commit squashed, message fixed |
There's no actual information in the commit about what we're doing here (probably notes about how we're removing 3.8 would be most relevant). |
Prior to this commit upgrades for osx running pe 3.8 were not possible. This commit adds special logic to remove pe 3.8 from osx. It also adds support for osx 10.10 and 10.11 as well as associated specs.
'pe-ruby-shadow', | ||
].each |$package| { | ||
exec { "forget ${package}": | ||
command => "/usr/sbin/pkgutil --forget com.puppetlabs.${package}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, the puppet osx package provider doesn't handle this? I'm disappointed. :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR's welcome. Unfortunately figuring out the signature of an installed package from a package name, without keeping state or running the installer, is a mystery to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should say I'm more disappointed in Apple for not writing a real package manager. It's definitely a hard problem to solve. Is there any way of getting a listing of all installed signatures so you could regex for package_name
and uninstall if there is only one match?
41be250
to
754dd49
Compare
@jpartlow @mwbutcher Just tested this out on a 3.8.3->2015.3 upgrade. Installed 3.8.3 on centos7, osx10.9. Verified mco ping/agent runs work. Upgraded centos7 master, verified agent runs work and puppet is not upgraded on agent. Installed puppet_agent module from this PR, added osx10.9 node to group with puppet_agent class applied, ran puppet/mco successfully. @jpartlow Did you have any additional comments/concerns on this PR or are we good to merge? |
👍 |
…09-upgrade Issue/master/pe 10914 add osx 109 upgrade
No description provided.