Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/master/pe 10914 add osx 109 upgrade #70

Merged

Conversation

mwbutcher
Copy link
Contributor

No description provided.

@mwbutcher mwbutcher force-pushed the issue/master/pe-10914-add-osx-109-upgrade branch 2 times, most recently from ec959de to 414f2fe Compare December 4, 2015 23:20
@MikaelSmith
Copy link
Contributor

Commit still says WIP.

@mwbutcher mwbutcher force-pushed the issue/master/pe-10914-add-osx-109-upgrade branch from 414f2fe to 41be250 Compare December 8, 2015 20:06
@mwbutcher
Copy link
Contributor Author

rebased, fixup commit squashed, message fixed

@jpartlow
Copy link
Contributor

jpartlow commented Dec 8, 2015

There's no actual information in the commit about what we're doing here (probably notes about how we're removing 3.8 would be most relevant).

Prior to this commit upgrades for osx running pe 3.8
were not possible.

This commit adds special logic to remove pe 3.8 from osx.
It also adds support for osx 10.10 and 10.11 as well as
associated specs.
'pe-ruby-shadow',
].each |$package| {
exec { "forget ${package}":
command => "/usr/sbin/pkgutil --forget com.puppetlabs.${package}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the puppet osx package provider doesn't handle this? I'm disappointed. :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR's welcome. Unfortunately figuring out the signature of an installed package from a package name, without keeping state or running the installer, is a mystery to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should say I'm more disappointed in Apple for not writing a real package manager. It's definitely a hard problem to solve. Is there any way of getting a listing of all installed signatures so you could regex for package_name and uninstall if there is only one match?

@mwbutcher mwbutcher force-pushed the issue/master/pe-10914-add-osx-109-upgrade branch from 41be250 to 754dd49 Compare December 8, 2015 21:19
@highb
Copy link
Contributor

highb commented Dec 8, 2015

@jpartlow @mwbutcher Just tested this out on a 3.8.3->2015.3 upgrade. Installed 3.8.3 on centos7, osx10.9. Verified mco ping/agent runs work. Upgraded centos7 master, verified agent runs work and puppet is not upgraded on agent. Installed puppet_agent module from this PR, added osx10.9 node to group with puppet_agent class applied, ran puppet/mco successfully.

@jpartlow Did you have any additional comments/concerns on this PR or are we good to merge?

@jpartlow
Copy link
Contributor

jpartlow commented Dec 8, 2015

👍

highb added a commit that referenced this pull request Dec 8, 2015
…09-upgrade

Issue/master/pe 10914 add osx 109 upgrade
@highb highb merged commit 075bca1 into puppetlabs:master Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants