Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strftime() deprecation warning #712

Merged

Conversation

smortex
Copy link
Contributor

@smortex smortex commented Apr 12, 2024

When running on Puppet 8, a warning is produced:

The argument signature (String format, [String timezone]) is deprecated for #strftime. See #strftime documentation and Timespan type for more info

Pass a timestamp as the first parameter to use a non-deprecated
signature of the function (Timespan $time_object, String $format).

When running on Puppet 8, a warning is produced:
```
The argument signature (String format, [String timezone]) is deprecated for #strftime. See #strftime documentation and Timespan type for more info
```

Pass a timestamp as the first parameter to use a non-deprecated
signature of the function `(Timespan $time_object, String $format)`.
@smortex smortex requested review from bastelfreak and a team as code owners April 12, 2024 00:52
@bastelfreak bastelfreak added the bug Something isn't working label Apr 12, 2024
@mhashizume
Copy link
Contributor

Thanks @smortex !

@mhashizume mhashizume merged commit 15f8033 into puppetlabs:main Apr 12, 2024
17 checks passed
@smortex smortex deleted the fix-strftime-deprecation-warning branch May 29, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants