(PE-12002) Add AIX support #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwbutcher
force-pushed
the
task/master/PE-12002_Add_AIX_support
branch
6 times, most recently
from
a4bd48e to
0c5747c
Compare
| }-> | ||
| user { 'pe-mcollective': | ||
| ensure => absent, | ||
| }-> |
There was a problem hiding this comment.
['pe-puppet', 'pe-mcollective'].each |$pkg| {
service { $pkg: ensure => stopped}
user { $pkg: ensure => absent }
}
04e4922 to
c319b77
Compare
|
@mwbutcher looks like the specs are failing. |
| @@ -49,6 +49,9 @@ | |||
| } | |||
| } elsif $::operatingsystem == 'Darwin' and $::macosx_productversion_major =~ '10\.[9,10,11]' { | |||
| $_package_file_name = "${puppet_agent::package_name}-${puppet_agent::params::master_agent_version}-1.osx${$::macosx_productversion_major}.dmg" | |||
| } elsif $::operatingsystem == 'aix' and $::architecture =~ 'PowerPC_POWER[5,6,7]' { | |||
| $aix_ver_number = regsubst($::architecture,'PowerPC_POWER(\d+)$','\1') | |||
| $_package_file_name = "${puppet_agent::package_name}-${puppet_agent::params::master_agent_version}-1.aix${aix_ver_number}.1.ppc.rpm" | |||
There was a problem hiding this comment.
AIX numbering is not always x.1 -- 5.3, 6.1, 7.1.
Which version where you testing?
mwbutcher
force-pushed
the
task/master/PE-12002_Add_AIX_support
branch
2 times, most recently
from
55db02f to
a83b9a3
Compare
This change adds puppet agent support for AIX. Support is gated by the 'aix' operatingsystem fact and an archetecture fact matching 'PowerPC_POWER[5,6,7]'. This change uses the same strategy as sles for removing unused packages as aix doesn't have fully fledged package management for rpms.
mwbutcher
force-pushed
the
task/master/PE-12002_Add_AIX_support
branch
from
a83b9a3 to
e5f6eef
Compare
mwbutcher
force-pushed
the
task/master/PE-12002_Add_AIX_support
branch
from
8586a97 to
1b98dc0
Compare
|
@mwbutcher Have you run pe_acceptance_tests against this already? |
|
👍 Verified this works by:
|
highb
added a commit
that referenced
this pull request
Jan 14, 2016
…pport (PE-12002) Add AIX support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds puppet agent support for AIX.
Support is gated by the 'aix' operatingsystem fact
and an architecture fact matching 'PowerPC_POWER[5,6,7]'.
This change uses the same strategy as osx for removing
unused packages as aix doesn't have fully fledged package
management for rpms.