(MODULES-3015) Fix SLES11 GPG key import issue #79
Conversation
|
@glarizza Looks like the lint checker doesn't like something about the indentation of the hashrockets? I'm not seeing it in the changes tab, what does it do when you run Log for future readers: |
| logoutput => 'on_failure', | ||
| path => '/bin:/usr/bin:/sbin:/usr/sbin', | ||
| command => "rpm --import ${gpg_path}", | ||
| unless => "rpm -q gpg-pubkey-$(echo $(gpg --homedir ${gpg_homedir} --throw-keyids < ${gpg_path}) | cut --characters=11-18 | tr [A-Z] [a-z])", |
There was a problem hiding this comment.
I'm trying to come up with less painful variations to this line and not coming up with much.
There is a minimal change that I think would be helpful:
rpm -q gpg-pubkey-$(gpg --homedir ${gpg_homedir} --throw-keyids --with-colons < ${gpg_path} | cut -d: -f5 | tr [A-Z] [a-z])
Should at least get away from specifying the character positions (which I think were off by one). Also I /think/ the echo was unnecessary?
Previously, the exec to import the Puppetlabs GPG key made a call out to the gpg binary to gather the hex value of the Puppetlabs GPG key. This call works from the console with an ENV, but it doesn't work when automated because it cannot find the relative homedir (~/.gnupg). To work around this, explicitly set the value for root's .gnupg homedir in the unless command and expose it as a variable should we need to deal with it later.
highb
force-pushed
the
MODULES_3015_sles_11_key_import
branch
from
5307fb4 to
63e6eb0
Compare
Prior to this commit the specs were failing due to changes in 63e6eb0 to the SLES GPG key handling. This commit updates the specs to match those changes.
|
Alright, updated the specs, fixed the linter nonsense, specs ran fine. 👍 Thanks for the fix! |
(MODULES-3015) Fix SLES11 GPG key import issue
Previously, the exec to import the Puppetlabs GPG key made a call out to the
gpg binary to gather the hex value of the Puppetlabs GPG key. This call works
from the console with an ENV, but it doesn't work when automated because it
cannot find the relative homedir (~/.gnupg). To work around this, explicitly
set the value for root's .gnupg homedir in the unless command and expose it as
a variable should we need to deal with it later.