(maint) Fix acceptance using Vagrant configs, allow flexible starting Puppet version #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2016 12:50
Changes to puppetserver defaults and beaker VM naming caused acceptance to start failing when using Vagrant. Add the full VM name to dns_alt_names and increase memory allocated to the master.
Previously acceptance tests would install puppet-agent 1.2.1, then install the latest puppetserver prompting an upgrade to a new version of puppet-agent. Now always install the latest puppet-agent and puppetserver. Also provide an environment variable, `PUPPET_CLIENT_VERSION` to allow specifying the starting Puppet version for acceptance tests. This provides a flexible way to run tests of Puppet from any prior version to the latest.
MikaelSmith
changed the title
|
This is helpful for testing #81. |
| @@ -45,7 +45,7 @@ def install_modules_on(host) | |||
| master['puppetservice'] = 'puppetserver' | |||
| master['puppetserver-confdir'] = '/etc/puppetlabs/puppetserver/conf.d' | |||
| master['type'] = 'aio' | |||
| install_puppet_agent_on master, {:puppet_agent_version => '1.2.1'} | |||
| install_puppet_agent_on master, {} | |||
There was a problem hiding this comment.
Is the {} necessary, since it's the default on the method signature?
There was a problem hiding this comment.
Yes, because the description did not match the actual call signature. See voxpupuli/beaker#1080.
highb
added a commit
that referenced
this pull request
Mar 14, 2016
(maint) Fix acceptance using Vagrant configs, allow flexible starting Puppet version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to puppetserver defaults and beaker VM naming caused acceptance
to start failing when using Vagrant. Add the full VM name to
dns_alt_names and increase memory allocated to the master.
Previously acceptance tests would install puppet-agent 1.2.1, then
install the latest puppetserver prompting an upgrade to a new version of
puppet-agent. Now always install the latest puppet-agent and
puppetserver.
Also provide an environment variable,
PUPPET_CLIENT_VERSIONto allowspecifying the starting Puppet version for acceptance tests. This
provides a flexible way to run tests of Puppet from any prior version to
the latest.