(maint) Update supported platforms #92
Conversation
MikaelSmith
force-pushed
the
support
branch
3 times, most recently
from
4aa7f5d to
bbb6669
Compare
Updates supported platforms for new package releases and platforms that were added but not noted as supported. Note that specific upgrade scenarios will still depend on Puppet being installed from packages prior to upgrade. `puppet-agent` packages should exist for all supported platforms.
Checking for osfamily == Amazon was a mistake, the osfamily will be RedHat. Repo names on Amazon instances need to be handled specially; they use EL 6 repos. Adds testing for Amazon OS.
Clarifies Puppet 3 version requirements.
| @@ -44,8 +44,6 @@ | |||
| } elsif $::operatingsystem == 'aix' and $::architecture =~ /PowerPC_POWER[5,6,7]/ { | |||
| $aix_ver_number = regsubst($::platform_tag,'aix-(\d+\.\d+)-power','\1') | |||
| $_package_file_name = "${puppet_agent::package_name}-${puppet_agent::params::master_agent_version}-1.aix${aix_ver_number}.ppc.rpm" | |||
| } elsif $::operatingsystem == 'Darwin' and $::macosx_productversion_major =~ /10\.[9,10,11]/ { | |||
There was a problem hiding this comment.
This section was redundant, see lines 42-43 above.
There was a problem hiding this comment.
Hm, must have been a bad re-base.
|
👍 sane changes to me, travis is passing. We just need to ensure that we test the module out on AWS AMI images at some point. |
| @@ -116,6 +112,7 @@ Specifically in the 1.1.0 Release: | |||
| * For Windows, you must trigger an agent run after upgrading so that Puppet can create the necessary directory structures. | |||
| * Upgrading from 2015.2.x to 2015.3.x is not yet supported. | |||
| * Solaris 11 is not yet supported. | |||
| * AIX package names are based on PowerPC architecture version. PowerPC 8 is not yet supported. | |||
There was a problem hiding this comment.
We could fix this by dropping the exclusion of PowerPC_POWER8. Happy to do that here or another PR.
There was a problem hiding this comment.
Yeah, either is fine to me. Maybe lets get it in another PR so we don't overload this one.
|
I tested the Amazon AMI manually for OSS. It's a challenge to setup, they don't provide I expect PE works, but that requires setting up a PE master in AWS to test against. |
|
👍 Let's just make another PR for the Power8 change. |
(maint) Update supported platforms
Updates supported platforms for new package releases, AIX PowerPC 8
hardware, and platforms that were added but not noted as supported.
Note that specific upgrade scenarios will still depend on Puppet being
installed from packages prior to upgrade.
puppet-agentpackages shouldexist for all supported platforms.