(PE-14463) Support 32-bit Windows via pe_repo #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in a PE environment against Windows 10 Enterprise (32-bit). |
When installing packages in a PE environment via pe_repo, only 64-bit packages were supported on Windows. Update to also support 32-bit packages.
|
Going to re-test this against the Puppet 4+ upgrade changes that you just merged. :) |
|
I'm rebasing and fixing a few things. |
|
Ah ok I'll wait up for that. |
|
Updated. |
|
@MikaelSmith The specs are still failing. |
added 2 commits
March 24, 2016 15:01
Adds spec tests for Windows-specific preparation, which primarily involves retrieving the MSI when in a PE environment.
Use the variable to ensure tests for same version use the same source.
|
Ok, I think it's fixed now. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing packages in a PE environment via pe_repo, only 64-bit
packages were supported on Windows. Update to also support 32-bit
packages.