Updating pe_metric to include additional metrics as per SUP-346 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the back of Agile Grooming meeting 15/5 I have added additional metrics as per SUP-346 |
Sharpie
requested changes
May 17, 2018
| 'url' => "puppetserver:name=puppetlabs.${::hostname}.puppetdb.report.convert_to_wire_format_hash" }, | ||
| { 'name' => 'puppetdb.command.submit.store report', | ||
| 'url' => "puppetserver:name=puppetlabs.${::hostname}.puppetdb.command.submit.store report" }, | ||
| ] |
There was a problem hiding this comment.
Since these metrics are specific to Puppet Server, the should go over to puppetserver.pp. The pe_metric.pp type is shared by all services, so having them here will apply the collection to PuppetDB and Orchestrator, where these measurements are not present.
The metrics should also be collected only if $::pe_server_version is less than 2018.1.0 as we've added these to the core set reported by the /status endpoint.
|
Closing in favor of PR #3. |
jarretlavallee
pushed a commit
that referenced
this pull request
Jul 11, 2019
Enables use_splunk_hec bool
m0dular
pushed a commit
to m0dular/puppetlabs-puppet_metrics_collector
that referenced
this pull request
Feb 19, 2020
This commit changes the create and tidy scripts to:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.