(SUP-2725) Fix system collection frequency

[m0dular]

Prior to this commit, the postgres and vmware classes didn't correctly
set the 'minute' parameter of the defined type for collecting metrics.
They lack the "0/" prefix, meaning for a default value of 5 we are
performing the collections on the 5th minute, not repeating every 5
minutes. This commit adds the prefix.

[puppet-community-rangefinder]

puppet_metrics_collector::system::postgres is a class

that may have no external impact to Forge modules.

puppet_metrics_collector::system::vmware is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[jarretlavallee]

We should add spec tests for the collection_interval to ensure all timers default to the same.

[m0dular]

Looks like we have a test for customizing $cron_minute in the defined type here, but this doesn't cover customizing collection_interval in the main classes. I'll add a test that customizes $collection_frequency in the two main classes.

[m0dular]

Added spec tests for all the timers that we customize via $collection_frequency.

[jarretlavallee]

👍

[jarretlavallee]

resolved #149