(SLV-767) Updated measurement tagging #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed regex that looked for puppet_server instead of puppetserver Added regex's for bolt and ace This means all of the services consistently get replaced and tagged instead of just some. removed the gc-stats regex as it wasn't used and was making it harder to make graphs using it.
|
@RandellP it looks like this needs a rebase. |
RandellP
changed the title
|
👍 |
|
Are we good to merge this? It seems like a good fit for the major release with #47. |
|
Well, you need 788 to go with it, or the dashboards will be broken since the tagging changes the paths to the measurements. |
|
@tkishel @jarretlavallee With SLV-788 merged, this should get merges as well, since they work together. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be merged at the same time as puppetlabs/puppet_metrics_dashboard#89
That will update the graphs to consume the date this will now produce
Fixed regex that looked for puppet_server instead of puppetserver
Added regex's for bolt and ace
This means all of the services consistently get replaced and tagged instead of just some.
removed the gc-stats regex as it wasn't used and was making it harder to make graphs using it.