Automate configuration of _hosts parameters and clarify documentation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit: Default <service_name>_hosts parameters are specified via a PuppetDB query. Installation and configuration documentation is prioritized. Module parameters are documented.
|
Four These change makes the module significantly easier to configure and comprehend, and allow it to be used by the HealthCheckLite project without manual configuration. |
tkishel
commented
Feb 5, 2019
| function puppet_metrics_collector::hosts_with_pe_profile($profile) { | ||
| if $settings::storeconfigs { | ||
| $_profile = capitalize($profile) | ||
| $hosts = puppetdb_query("resources[certname] { |
There was a problem hiding this comment.
I wonder if this should have specified environment to only return hosts in the current environment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit:
Default <service_name>_hosts parameters are specified via a PuppetDB query.
Installation and configuration documentation is prioritized.
Module parameters are documented.