Ensure tidy's tar captures large numbers of files #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. The CI failures should be fixed with a PDK update. |
|
Do we know if this will work on all Master platforms? |
|
I checked Ubuntu 14.04 and Centos 6 and it was there. |
When a large number of files are being archived xargs might invoke tar multiple times - overwriting the preceding tar archive. Using the "--files-from" option to tar instead lets all files be correctly archived.
npwalker
force-pushed
the
fix_many_files_tidy
branch
from
28a0d4a
to
2853157
Compare
npwalker
approved these changes
Jan 25, 2019
|
Thanks @seanmil !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a large number of files are being archived xargs might invoke
tar multiple times - overwriting the preceding tar archive. Using
the "--files-from" option to tar instead lets all files be correctly
archived.