Standardize cleanup of temp files #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of an error or if the files were otherwise deleted, the previous commit would try to delete $tmp twice. This commit adds an array to hold the temp file names and deletes them on exit, checking the existence of each one. Also check if $metrics_tmp is >0 bytes before running xargs. It could be empty if there are no files to tidy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of an error or if the files were otherwise deleted, the
previous commit would try to delete $tmp twice. This commit adds an
array to hold the temp file names and deletes them on exit, checking the
existence of each one.
Also check if $metrics_tmp is >0 bytes before running xargs. It could
be empty if there are no files to tidy.