Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default chmod behaviour, update xinetd dependency. #80

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nosmo
Copy link

@nosmo nosmo commented Jun 21, 2016

Until after v3.0.7, rsync's chmod directives completely ignored octal chmods, only paying attention to "Du+rwx"-style specifiers. When upgrading from rsync v3.0.7 to v3.0.10, I hit an issue wherein rsynced directories became inaccessible because the 644 permissions are applied to all files and directories, and directories lacked executable bits. Rather than change this chmod to a comprehensive "Du+rwx,go+rx,Fu+rwx,go+r", I think it makes sense to disable the chmod by default and allow users to configure their own chmods per-module and otherwise maintain the original modes set on files.

This PR also updates the fixtures to use the now-puppetlabs-maintained xinetd repository and updates test facts accordingly.

@esalberg
Copy link
Contributor

esalberg commented Aug 3, 2016

I have a separate PR also dealing with chmod, but in a different manifest. We should make sure that they don't conflict (I think they should be okay?):
#83

@eputnam
Copy link
Contributor

eputnam commented Nov 16, 2017

@nosmo , if you're still interested in getting this in, would you mind rebasing on master?

@nosmo
Copy link
Author

nosmo commented Nov 20, 2017

Rebased!

@eputnam
Copy link
Contributor

eputnam commented Nov 21, 2017

@nosmo I guess I'd rather see the defaults changed than dropping them altogether. Seems like these are defaults that a lot of people probably rely on.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Hugh Nowlan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants