(MODULES-10101) Use RunOnLastWeekOfMonth for which_occurrence = last

[sanfrancrisko]

Description

We were not correctly determining the idempotency of a scheduled task that had a MonthlyDOWTrigger set to last:

'which_occurrence' => 'last'

The task was being correctly set on the Windows Server instances, but when we read back the task, we were determining that the Task.Definition.Triggers[i].WeeksOfMonth attribute was 0 (i.e. nothing defined). Instead, we should be checking the RunOnLastWeekOfMonth to determine if the task is set to run on the last week of the month.

NOTE: We are not changing how this parameter is configured, just how it is read back.

Tests

• pdk validate successfully passes
• Existing acceptance tests pass on all compatible OSs
• New acceptance tests pass on all compatible OSs

[codecov-io]

Codecov Report

Merging #119 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   95.41%   95.42%   +<.01%     
==========================================
  Files           6        6              
  Lines         829      830       +1     
==========================================
+ Hits          791      792       +1     
  Misses         38       38

Impacted Files	Coverage Δ
lib/puppet_x/puppetlabs/scheduled_task/trigger.rb	95.03% <100%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc24455...c1b9309. Read the comment docs.