(MODULES-10893) Fix Last Day Of Month Trigger #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
force-pushed
the
MODULES-10893-fix-last-day-of-month
branch
from
5f24243 to
a59945d
Compare
sanfrancrisko
suggested changes
Dec 16, 2020
Contributor
sanfrancrisko
left a comment
sanfrancrisko
left a comment
There was a problem hiding this comment.
Just one minor issue, but overall looks good 👍
Thanks for picking this up and addressing - took some work off my plate today 😃
RandomNoun7
force-pushed
the
MODULES-10893-fix-last-day-of-month
branch
from
a59945d to
f870e90
Compare
RandomNoun7
force-pushed
the
MODULES-10893-fix-last-day-of-month
branch
4 times, most recently
from
d1538e0 to
7039ecf
Compare
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 94.97% 95.02% +0.04%
==========================================
Files 6 6
Lines 836 844 +8
==========================================
+ Hits 794 802 +8
Misses 42 42
Continue to review full report at Codecov.
|
RandomNoun7
force-pushed
the
MODULES-10893-fix-last-day-of-month
branch
3 times, most recently
from
682314c to
5995d0e
Compare
RandomNoun7
force-pushed
the
MODULES-10893-fix-last-day-of-month
branch
2 times, most recently
from
1ec8c87 to
1133c06
Compare
Prior to this change, attempting to create a trigger that will run on
the last day of each selected month will fail. The error claims that a
a value is out of range
```
OLE error code:0 in <Unknown>
<No Description>
HRESULT error code:0x8002000a
Out of present range.
```
Microsoft [documentation] claims in one place that the correct way to
specify the last day of a month is to effectively translate a bitmask
value of day 32 and pass that into the `{get:set}_DaysOfMonth` method
on the trigger object. The module was previously coded to do exactly
this. The provider and it's helpers would catch the string value 'last'
in the `on` property of a `monthly` trigger and translate it into the
bit mask. This is what resulted in the error, because it turns out that
the position for day 32 in the bit mast is outside the acceptable range
of values for this property.
This PR changes strategy and instead relies on a different section
of the documentation in which an entirely different property on the
trigger object called [RunOnLastDayOfMonth] is set.
The code now catches the string value 'last' in the `on` property of
the trigger, and sets this boolean on the trigger object.
Testing has shown this to be an effective method of managing this
property of a trigger.
[documentation]: https://docs.microsoft.com/en-gb/windows/win32/api/taskschd/nf-taskschd-imonthlytrigger-get_daysofmonth
[RunOnLastDayOfMonth]: https://docs.microsoft.com/en-gb/windows/win32/api/taskschd/nf-taskschd-imonthlytrigger-put_runonlastdayofmonth
RandomNoun7
force-pushed
the
MODULES-10893-fix-last-day-of-month
branch
from
1133c06 to
779908b
Compare
sanfrancrisko
approved these changes
Dec 17, 2020
Contributor
sanfrancrisko
left a comment
sanfrancrisko
left a comment
There was a problem hiding this comment.
Excellent, thanks for this @RandomNoun7 👍
DavidS
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, attempting to create a trigger that will run on
the last day of each selected month will fail. The error claims that a
a value is out of range
Microsoft documentation claims in one place that the correct way to
specify the last day of a month is to effectively translate a bitmask
value of day 32 and pass that into the
{get:set}_DaysOfMonthmethodon the trigger object. The module was previously coded to do exactly
this. The provider and it's helpers would catch the string value 'last'
in the
onproperty of amonthlytrigger and translate it into thebit mask. This is what resulted in the error, because it turns out that
the position for day 32 in the bit mast is outside the acceptable range
of values for this property.
This PR changes strategy and instead relies on a different section
of the documentation in which an entirely different property on the
trigger object called RunOnLastDayOfMonth is set.
The code now catches the string value 'last' in the
onproperty ofthe trigger, and sets this boolean on the trigger object.
Testing has shown this to be an effective method of managing this
property of a trigger.