Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) - Fixing rubocop failures #240

Closed
wants to merge 0 commits into from

Conversation

rajat-puppet
Copy link
Contributor

Summary

Fixing rubocop failures

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@rajat-puppet rajat-puppet marked this pull request as ready for review September 25, 2023 08:46
@rajat-puppet rajat-puppet requested a review from a team as a code owner September 25, 2023 08:46
Copy link
Contributor

@Ramesh7 Ramesh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we fix it over putting into skipping list?

@rajat-puppet
Copy link
Contributor Author

rajat-puppet commented Sep 25, 2023

can we fix it over putting into skipping list?

The issue is not with the file but with the way describe block has been written to use Trigger model using the namespace, tried correcting it but didn't make any sense, so I put it up on the exclude list.

@Ramesh7 Ramesh7 closed this Sep 25, 2023
@Ramesh7 Ramesh7 force-pushed the maint-fix-rubocop-warning branch from 98cd16c to 607b5eb Compare September 25, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants