Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-7203) Support nonroot task folders #83

Merged
merged 1 commit into from
May 22, 2019
Merged

(MODULES-7203) Support nonroot task folders #83

merged 1 commit into from
May 22, 2019

Conversation

michaeltlombardi
Copy link
Contributor

@michaeltlombardi michaeltlombardi commented May 20, 2019

Prior to this commit the type and providers did not support specifying subfolders in which
to place a scheduled task. This commit adds support to the type and the taskscheduler_api2
provider for specifying scheduled tasks in subfolders.

This feature only exists for tasks whose compatibility is 2 or higher which prevents it from
being used on the legacy win32_taskscheduler provider altogether and necessitates some
validation prior to runtime.

This commit adds such validation by failing with descriptive errors during resource validation.

This new functionality requires the ability to scaffold folders in which to place the scheduled
task, which now happens automatically and only if the folder path does not already exist.

This commit does NOT add functionality for pruning the folders on task deletion, this should be
addressed in a future commit.

It does update the documentation and tests for the new feature as well as ensure all existing
tests continue to pass.

@michaeltlombardi michaeltlombardi changed the title (WIP)(MODULES-7203) Support nonroot task folders (MODULES-7203) Support nonroot task folders May 21, 2019
@michaeltlombardi
Copy link
Contributor Author

This is working its way through Jenkins now. :)

@michaeltlombardi
Copy link
Contributor Author

Passed adhoc!

Prior to this commit the type and providers did not support specifying subfolders in which
to place a scheduled task. This commit adds support to the type and the taskscheduler_api2
provider for specifying scheduled tasks in subfolders.

This feature only exists for tasks whose compatibility is 2 or higher which prevents it from
being used on the legacy win32_taskscheduler provider altogether and necessitates some
validation prior to runtime.

This commit adds such validation by failing with descriptive errors during resource validation.

This new functionality requires the ability to scaffold folders in which to place the scheduled
task, which now happens automatically and only if the folder path does not already exist.

This commit does NOT add functionality for pruning the folders on task deletion, this should be
addressed in a future commit.

It does update the documentation and tests for the new feature as well as ensure all existing
tests continue to pass.
@RandomNoun7 RandomNoun7 merged commit 961049e into puppetlabs:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants