-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-7203) Support nonroot task folders #83
Merged
RandomNoun7
merged 1 commit into
puppetlabs:master
from
michaeltlombardi:ticket/master/modules-7203-support-nonroot-task-folders
May 22, 2019
Merged
(MODULES-7203) Support nonroot task folders #83
RandomNoun7
merged 1 commit into
puppetlabs:master
from
michaeltlombardi:ticket/master/modules-7203-support-nonroot-task-folders
May 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
May 21, 2019
glennsarti
reviewed
May 21, 2019
glennsarti
reviewed
May 21, 2019
glennsarti
reviewed
May 21, 2019
glennsarti
reviewed
May 21, 2019
michaeltlombardi
changed the title
(WIP)(MODULES-7203) Support nonroot task folders
(MODULES-7203) Support nonroot task folders
May 21, 2019
This is working its way through Jenkins now. :) |
Passed adhoc! |
RandomNoun7
reviewed
May 22, 2019
Prior to this commit the type and providers did not support specifying subfolders in which to place a scheduled task. This commit adds support to the type and the taskscheduler_api2 provider for specifying scheduled tasks in subfolders. This feature only exists for tasks whose compatibility is 2 or higher which prevents it from being used on the legacy win32_taskscheduler provider altogether and necessitates some validation prior to runtime. This commit adds such validation by failing with descriptive errors during resource validation. This new functionality requires the ability to scaffold folders in which to place the scheduled task, which now happens automatically and only if the folder path does not already exist. This commit does NOT add functionality for pruning the folders on task deletion, this should be addressed in a future commit. It does update the documentation and tests for the new feature as well as ensure all existing tests continue to pass.
RandomNoun7
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the type and providers did not support specifying subfolders in which
to place a scheduled task. This commit adds support to the type and the taskscheduler_api2
provider for specifying scheduled tasks in subfolders.
This feature only exists for tasks whose compatibility is 2 or higher which prevents it from
being used on the legacy win32_taskscheduler provider altogether and necessitates some
validation prior to runtime.
This commit adds such validation by failing with descriptive errors during resource validation.
This new functionality requires the ability to scaffold folders in which to place the scheduled
task, which now happens automatically and only if the folder path does not already exist.
This commit does NOT add functionality for pruning the folders on task deletion, this should be
addressed in a future commit.
It does update the documentation and tests for the new feature as well as ensure all existing
tests continue to pass.