Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8230) Convert testing to litmus #1031

Merged
merged 1 commit into from
Jul 4, 2019
Merged

(FM-8230) Convert testing to litmus #1031

merged 1 commit into from
Jul 4, 2019

Conversation

eimlav
Copy link
Contributor

@eimlav eimlav commented Jun 20, 2019

No description provided.

@eimlav eimlav added the feature label Jun 20, 2019
@eimlav eimlav changed the title (FM-8230) Convert testing to litmus [WIP] (FM-8230) Convert testing to litmus Jun 20, 2019
@eimlav eimlav force-pushed the fm-8230 branch 3 times, most recently from 4e7a32e to 993d51d Compare June 25, 2019 13:28
spec/acceptance/build_csv.rb Show resolved Hide resolved
spec/acceptance/has_interface_with_spec.rb Show resolved Hide resolved
@eimlav
Copy link
Contributor Author

eimlav commented Jun 27, 2019

@tphoney I have left some updates on your comments.

@eimlav
Copy link
Contributor Author

eimlav commented Jun 27, 2019

@RandomNoun7 Removed pry. If everything else looks good would you be able to merge? Cheers!

@eimlav eimlav changed the title [WIP] (FM-8230) Convert testing to litmus (FM-8230) Convert testing to litmus Jul 1, 2019
@eimlav eimlav requested a review from RandomNoun7 July 2, 2019 13:37
Copy link

@RandomNoun7 RandomNoun7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit and I'm happy to merge.

spec/acceptance/anchor_spec.rb Outdated Show resolved Hide resolved
@tphoney tphoney merged commit 19ace45 into master Jul 4, 2019
@eimlav eimlav deleted the fm-8230 branch July 4, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants