[MODULES-10729] defined_with_params - unnamed type #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where trying to match against any declared defined
type with a specific parameter would never return that there was a match
in the catalog.
This is relevant when trying to ensure that you don't have port
conflicts in services that can declare multiple instances of a service
through a given defined type, such as Apache.
This, previously valid call to the function now works as expected:
``defined_with_params(My::DefinedType, { 'port' => 1337 })``
MODULES-10729 #close
defined_with_params is a functionBreaking changes to this file MAY impact these 7 modules (near match):This module is declared in 318 of 575 indexed public
|
sanfrancrisko
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where trying to match against any declared defined
type with a specific parameter would never return that there was a match
in the catalog.
This is relevant when trying to ensure that you don't have port
conflicts in services that can declare multiple instances of a service
through a given defined type, such as Apache.
This, previously valid call to the function now works as expected:
defined_with_params(My::DefinedType, { 'port' => 1337 })MODULES-10729 #close