Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bugfix) Setting stricter email validation #1163

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Feb 10, 2021

Setting stricter email validation. Currently this type allows for new lines.
This fix is in relation to the following comment: #1160 (comment)

Thank you for bringing this to our attention @pegasd 👍

@pmcmaw pmcmaw requested a review from a team as a code owner February 10, 2021 11:28
@pmcmaw pmcmaw force-pushed the test_emails branch 2 times, most recently from e87a34d to 65e3cf3 Compare February 10, 2021 11:57
@pmcmaw pmcmaw changed the title testing email (bugfix) Setting stricter email validation Feb 10, 2021
@pmcmaw pmcmaw added the bugfix label Feb 10, 2021
@pmcmaw pmcmaw mentioned this pull request Feb 10, 2021
@pegasd
Copy link
Contributor

pegasd commented Feb 10, 2021

This looks great! Thanks for going the extra mile for this!

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Feb 10, 2021

@pegasd Not a problem at all, thank you for highlighting.
:-) I will send to the team for review and hopefully a merge.

@DavidS DavidS merged commit 3373a08 into puppetlabs:main Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants