Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os_version_gte: fix version comparison logic #1207

Merged
merged 2 commits into from
Aug 29, 2021
Merged

os_version_gte: fix version comparison logic #1207

merged 2 commits into from
Aug 29, 2021

Conversation

kenyon
Copy link
Contributor

@kenyon kenyon commented Aug 27, 2021

Closes #1206.

@kenyon kenyon requested a review from a team as a code owner August 27, 2021 20:49
@puppet-community-rangefinder
Copy link

os_version_gte is a function

that may have no external impact to Forge modules.

This module is declared in 319 of 578 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@kenyon kenyon changed the title os_version_gte: fix fix version comparison logic os_version_gte: fix version comparison logic Aug 27, 2021
@kenyon
os_version_gte: fix and add tests
d41611b 
As reported in
<puppetlabs#972 (comment)>,
os_version_gte is not returning correct results. This commit fixes the
tests to demonstrate correct expected behavior.
@kenyon
os_version_gte: fix version comparison logic
144e24d 
Closes puppetlabs#1206.
@kenyon
Copy link
Contributor Author

kenyon commented Aug 27, 2021

This is ready.

@smortex smortex added the bugfix label Aug 27, 2021
smortex
smortex approved these changes Aug 27, 2021
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ekohl
ekohl approved these changes Aug 29, 2021
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl merged commit 64d87d2 into puppetlabs:main Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenyon @smortex @ekohl