-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FEAT) Add function parsepson #1259
(FEAT) Add function parsepson #1259
Conversation
parsepson is a functionthat may have no external impact to Forge modules. This module is declared in 318 of 579 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be written as a modern function rather than the legacy one? You also have parsejson
in the PR title and commit message, which should be parsepson
.
729ef62
to
bdf9e36
Compare
Had just copied the original function pre changes, but modernizing it would probably be good. |
3f1b791
to
1cd4ec5
Compare
1cd4ec5
to
c3ad329
Compare
f74a389
to
fa64f90
Compare
fa64f90
to
99a9254
Compare
This commit adds a new function to parse PSON formatted JSON. This functionality was formally covered by `parsejson` which, despite its name, defaulted to PSON. However this has been changed so that the function now accurately uses JSON, with this function being added to cover the potential need for PSON too specifically be used.
99a9254
to
0f032a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as failing spec tests are currently present on main.
Following ekohls suggestion of using the newer function style this is something on the teams radar and will be addressed as soon as we have bandwidth.
That's good, but IMHO we should at least only add new style functions (as we did here). Conversion is lower priority. |
And possibly also only allow new functions if they are namespaced too? |
I feel stdlib is always a bit different. All other modules should certainly only have namespaced functions but stdlib is in this weird place. Perhaps best to discuss it in its own issue? |
This commit adds a new function to parse PSON formatted JSON.
This functionality was formally covered by
parsejson
which, despite its name, defaulted to PSON.However this has been changed so that the function now accurately uses JSON, with this function covering the potential need for PSON too specifically be used.