Check if file exists before loading with loadyaml. If not, return nil #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @amateo, thanks for the contribution, and apologies it took so long for us to review this. Do you think you could update tests in https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/spec/functions/loadyaml_spec.rb to check the case where the file exists? Thanks! |
|
I have added a test for the case when the file does not exist. The case in when it exists, it is already included in existent tests |
That doesn't seem to be included in this PR. |
|
Sorry, I forgot to push the changes to github repository. I think they are now. |
underscorgan
pushed a commit
that referenced
this pull request
Apr 16, 2015
Check if file exists before loading with loadyaml. If not, return nil
|
Great, thanks @amateo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
loadyamlfunction, check if file exists before trying to import. If not exists, return nil.