Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use properly encoded characters #542

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Nov 3, 2015

This is more severe than it sounds. These characters make puppet fail with the following message :

Error 400 on SERVER: "\xC3" on US-ASCII

This is more severe than it sounds. These characters make puppet fail with the following message : 

> Error 400 on SERVER: "\xC3" on US-ASCII
HelenCampbell pushed a commit that referenced this pull request Nov 6, 2015
use properly encoded characters
@HelenCampbell HelenCampbell merged commit 5d8a5ac into puppetlabs:master Nov 6, 2015
@HelenCampbell
Copy link
Contributor

Thank you :)

@greg0ire greg0ire deleted the patch-1 branch November 6, 2015 17:16
@igalic
Copy link
Contributor

igalic commented Nov 7, 2015

really?

if i put my own name (Galić) in .pp files it fails with the same reason.
particularly in apply mode :(

but then again, é is in US-ASCII, ć is not…

@greg0ire
Copy link
Contributor Author

greg0ire commented Nov 7, 2015

Yeah, I don't know why US-ASCII is being use here rather than utf-8…

@igalic
Copy link
Contributor

igalic commented Nov 7, 2015

bizarrely, it's the ruby default, starting 1.9, unless you tell it to use unicode…

@greg0ire
Copy link
Contributor Author

greg0ire commented Nov 7, 2015

you tell it to use unicode…

Guess this is what actually needs to be fixed…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants