Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check if Gem is defined #579

Merged
merged 1 commit into from
Mar 28, 2016
Merged

Add check if Gem is defined #579

merged 1 commit into from
Mar 28, 2016

Conversation

sulaweyo
Copy link
Contributor

On e.g. Ubuntu 12.04 LTS Gem is not there by default so i added a check to not fail in that fact if this is the case.

On e.g. Ubuntu 12.04 LTS Gem is not there by default so i added a check to not fail in that fact if this is the case.
@bmjen
Copy link
Contributor

bmjen commented Mar 21, 2016

@sulaweyo What version of rubygems and ruby are you running? It sounds weird that any installation of puppet (far enough to run facter) on any OS would not have Gem installed and defined.

@sulaweyo
Copy link
Contributor Author

It popped up in our CI. It was some Ubuntu 12.04 LTS which did not have all current updates in (for a bunch of reasons). Others worked fine so it's most likely because of missing updates but still i'd say to check if Gem it there is never wrong to do.

Sorry i can not say which exact version was in there. Most likely the latest puppet version in ubuntu repos which was something around 3.4. As this failed my puppet runs i just added the check and wanted to make sure others don't run into this as well.

@bmjen
Copy link
Contributor

bmjen commented Mar 28, 2016

@sulaweyo Sounds good. I agree that it's not a significant change to add a check. Thanks!

@bmjen bmjen merged commit b63849c into puppetlabs:master Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants