Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the default value to the "loadyaml" function #600

Merged
merged 1 commit into from
May 12, 2016

Conversation

dmitryilyin
Copy link

This value will be returned if the is no file to load or a file could not be parsed.
It's similar to the "parseyaml" function's default value.

Add the "loadjson" function too.

@dmitryilyin dmitryilyin force-pushed the master branch 3 times, most recently from aa8d57f to 870a272 Compare April 26, 2016 18:58
This value will be returned if the is no file
to load or a file could not be parsed.
It's similar to the "parseyaml" function's
default value.

Add the "loadjson" function too
@dmitryilyin
Copy link
Author

ping

@jonnytdevops
Copy link
Contributor

@bmjen This PR looks good to me. Do you think we can merge this or would this be a breaking change?

@bmjen
Copy link
Contributor

bmjen commented May 12, 2016

This looks fine. It does not appear backwards incompatible, as any incorrect call to loadyaml without a default will still yield the same result.

Thanks for the contribution @dmitryilyin !

@bmjen bmjen merged commit ecfdbb2 into puppetlabs:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants