(MODULES-3980) Fix ipv4 regex validator #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like everything else, this is currently blocked on #678 |
Closed
DavidS
force-pushed
the
modules-3980-fix-ipv4-regex
branch
from
9a2d24c
to
4a01169
Compare
This also updates all ipv4 tests to use the same test data for better comparability. Closes puppetlabs#676, puppetlabs#679 Fix-Originally-By: Nate Potter <nathaniel.potter@intel.com>
DavidS
force-pushed
the
modules-3980-fix-ipv4-regex
branch
from
4a01169
to
ea92941
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates all ipv4 tests to use the same test data for better
comparability. Closes #676, #679
Fix-Originally-By: Nate Potter nathaniel.potter@intel.com