[MODULES-4528] Replace Puppet.version.to_f version comparison from spec_helper.rb #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uhm… what does the title / commit message of this PR have to do with the changes? |
|
@igalic I know this is somewhat confusing but what happened is that as a result of MODULES-4528 I have needed to do a modulesync run to replace Puppet.version.to_f in the spec/spec_helper.rb file. However when I went to do the msync run it turns out that there are pending changes put into the modulesync configs that have not yet been modulesync'd out to the modules. Rather than doing this in 2 different runs across all our modules I thought its better to combine both changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.