Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-5680) Added new function sprintf_hash to allow using named references #824

Merged
merged 2 commits into from
Nov 2, 2017
Merged

(MODULES-5680) Added new function sprintf_hash to allow using named references #824

merged 2 commits into from
Nov 2, 2017

Conversation

vStone
Copy link
Contributor

@vStone vStone commented Oct 4, 2017

See docs, tests

@vStone
Copy link
Contributor Author

vStone commented Oct 4, 2017

Not sure why windows doesn't like this... :/

@vStone vStone force-pushed the feature/new_function_sprintf_hash branch from 4bad315 to 6d714bb Compare October 4, 2017 06:08
@vStone vStone changed the title Added new function sprintf_hash to allow using named references (MODULES-5680) Added new function sprintf_hash to allow using named references Oct 4, 2017
@david22swan
Copy link
Member

Test's failed a second time when rekicked. Unable to merge at this time

@david22swan
Copy link
Member

All failures seem to originate from line 22 of lib/puppet/functions/sprintf_hash.rb

@david22swan
Copy link
Member

david22swan commented Nov 1, 2017 •
edited
Loading

@vStone
Any movement on this??
Be warned that I'm moving to do a clean release so anything that isn't merged will be closed.
No offense intended

@vStone
Copy link
Contributor Author

vStone commented Nov 1, 2017 •
edited
Loading

Although the documentation suggests return_type should be usable from puppet 4.7, looks like its not quite the case.

@david22swan david22swan merged commit bbb29a4 into puppetlabs:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vStone @david22swan @jordanbreen28