Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle join_keys_to_values() with undef values. #874

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Handle join_keys_to_values() with undef values. #874

merged 1 commit into from
Jan 23, 2018

Conversation

BobVanB
Copy link
Contributor

@BobVanB BobVanB commented Jan 22, 2018

support flags

gitlab_ci_runners_defaults:
  tag-list: 'custom'
  run-untagged:
  executor: 'shell'

(gitlab module joins on space)
would become:
--tag-list custom --run-untagged --executor shell

the --run-untagged does not accept values.

Because puppet and hieradata returns string values i had to use String(v) == "undef".
I couldn't get it to work with not defined?(v) or v.nil?.

@hunner hunner changed the title Update join_keys_to_values with an undef statement. Handle join_keys_to_values() with undef values. Jan 23, 2018
@hunner hunner added the bugfix label Jan 23, 2018
@hunner hunner merged commit 1dd3b92 into puppetlabs:master Jan 23, 2018
hunner added a commit that referenced this pull request Jan 23, 2018
Handle join_keys_to_values() with undef values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants