Modules 7472 - Websphere_application_server: Instance installation fails with nil conversion #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionce
force-pushed
the
MODULES-7472
branch
2 times, most recently
from
bc89bab to
f9179c6
Compare
eimlav
reviewed
Apr 15, 2019
README.md
Outdated
| ```puppet | ||
| class { 'websphere_application_server': | ||
| user => 'webadmin', | ||
| group => 'webadmins', | ||
| base_dir => '/opt/IBM', |
There was a problem hiding this comment.
As this is for root user, it should be left unchanged.
eimlav
reviewed
Apr 15, 2019
| @@ -52,10 +54,19 @@ The primary difference here being the `base_dir`. Set this to a dir your user ha | |||
| class { 'websphere_application_server': | |||
| user => 'webadmin', | |||
| group => 'webadmins', | |||
There was a problem hiding this comment.
Worth including the base_dir here too as it is mentioned as part of the setup.
|
@lionce I've left a few minor changes for you to look at. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed websphere_application_server instance installation using 'root' user
