Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Puppet Plan which can be used to clone an IBM WAS Package/FixPack repository #188

Merged
merged 5 commits into from
Mar 3, 2020

Conversation

psreed
Copy link
Contributor

@psreed psreed commented Jan 15, 2020

Likely needs some testing. I wrote this plan last week and modified it heavily to include here in the official WAS plugin. See documentation in line within the plan itself.

@psreed psreed requested a review from a team as a code owner January 15, 2020 18:20
@codecov-io
Copy link

codecov-io commented Jan 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b9df98a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #188   +/-   ##
========================================
  Coverage          ?   5.33%           
========================================
  Files             ?      26           
  Lines             ?    2568           
  Branches          ?       0           
========================================
  Hits              ?     137           
  Misses            ?    2431           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9df98a...7f70abc. Read the comment docs.

@lionce
Copy link
Contributor

lionce commented Jan 16, 2020

Hello @psreed ,

Thank you for this contribution. In order to merge it, please add some tests to cover these changes.

Cheers!

@psreed
Copy link
Contributor Author

psreed commented Jan 21, 2020

@lionce I'd love to.... just not quite sure how. I'll gladly do it, but any chance you can point me at an example for how tests for Bolt plans are normally done?

@carabasdaniel
Copy link
Contributor

Hi @psreed

Thanks for submitting this PR. In order to run tests for Bolt plans or Bolt tasks you can use the documentation from https://github.com/puppetlabs/bolt/blob/master/developer-docs/bolt_spec-run.md.

See the example guide for writing tasks here: https://puppet.com/blog/writing-robust-bolt-tasks-guide/

@sheenaajay
Copy link
Contributor

Thanks @psreed for submitting the PR. We can always accept new PR for blot plan tests. Looking for more contribution.

@sheenaajay sheenaajay merged commit e06ef74 into master Mar 3, 2020
@david22swan david22swan deleted the bolt_repo_plan branch July 22, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants