Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-factory_bot requirement from != 2.26.0 to >= 0 #464

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jun 12, 2024

Updates the requirements on rubocop-factory_bot to permit the latest version.

Release notes

Sourced from rubocop-factory_bot's releases.

RuboCop FactoryBot v2.26.0

  • Fix a false positive for FactoryBot/AssociationStyle when using nested factories with traits. (@​jaydorsey)
  • Support AutoCorrect: contextual option for LSP. (@​ydah)
Changelog

Sourced from rubocop-factory_bot's changelog.

2.26.0 (2024-06-08)

  • Fix a false positive for FactoryBot/AssociationStyle when using nested factories with traits. ([@​jaydorsey])
  • Support AutoCorrect: contextual option for LSP. ([@​ydah])

2.25.1 (2024-01-08)

  • Fix a false positive for FactoryBot/CreateList when create call does have method calls and repeat multiple times with other argument. ([@​ydah])
  • Fix an error occurred for FactoryBot/IdSequence when sequence with non-symbol argument or without argument. ([@​ydah])

2.25.0 (2024-01-04)

  • Fix a false positive for FactoryBot/FactoryNameStyle when namespaced models. ([@​ydah])
  • Add new FactoryBot/ExcessiveCreateList cop. ([@​ddieulivol])
  • Fix a false positive for FactoryBot/ConsistentParenthesesStyle when hash pinning. ([@​ydah])

2.24.0 (2023-09-18)

  • Fix FactoryBot/AssociationStyle cop to ignore explicit associations with strategy: :build. ([@​pirj])
  • Change FactoryBot/CreateList so that it is not an offense if not repeated multiple times. ([@​ydah])
  • Fix a false positive for FactoryBot/AssociationStyle when association is called in trait block and column name is keyword. ([@​ydah])
  • Fix a false positive for FactoryBot/AssociationStyle when EnforcedStyle: Explicit and using trait within trait. ([@​ydah])
  • Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically, FactoryBot/CreateList and FactoryBot/FactoryClassName to work with minitest style directory. ([@​ydah])
  • Add FactoryBot/IdSequence cop. ([@​owst])

2.23.1 (2023-05-15)

  • Fix FactoryBot/AssociationStyle cop for a blockless factory. ([@​pirj])

2.23.0 (2023-05-15)

  • Add FactoryBot/FactoryAssociationWithStrategy cop. ([@​morissetcl])
  • Mark FactoryBot/CreateList as SafeAutoCorrect: false. ([@​r7kamura])
  • Change FactoryBot/CreateList so that it considers times.map. ([@​r7kamura])
  • Add FactoryBot/RedundantFactoryOption cop. ([@​r7kamura])
  • Add ExplicitOnly configuration option to FactoryBot/ConsistentParenthesesStyle, FactoryBot/CreateList and FactoryBot/FactoryNameStyle. ([@​ydah])
  • Change FactoryBot/CreateList so that it checks same factory calls in an Array. ([@​r7kamura])
  • Add FactoryBot/AssociationStyle cop. ([@​r7kamura])

2.22.0 (2023-05-04)

  • Extracted from rubocop-rspec into a separate repository for easier use with Minitest/Cucumber. ([@​ydah])

Previously (see rubocop-rspec's changelist for details)

  • Fix a false positive for RSpec/FactoryBot/ConsistentParenthesesStyle inside &&, || and :? when omit_parentheses is on. ([@​dmitrytsepelev])
  • Add new RSpec/FactoryBot/FactoryNameStyle cop. ([@​ydah])
  • Fix wrong autocorrection in n_times style on RSpec/FactoryBot/CreateList. ([@​r7kamura])
  • Fix a false positive for RSpec/FactoryBot/ConsistentParenthesesStyle when using generate with multiple arguments. ([@​ydah])
  • Fix RSpec/FactoryBot/ConsistentParenthesesStyle to ignore calls without the first positional argument. ([@​pirj])

... (truncated)

Commits
  • ba7b16d Merge pull request #123 from rubocop/release-2_26
  • 940f06e Release v2.26.0
  • adc6f57 Merge pull request #122 from rubocop/add-gh-token
  • 22fd70d Merge pull request #121 from rubocop/publish-workflow
  • 8b43931 Add GH_TOKEN to publish workflow
  • 527e6da Fix a publish workflow
  • 932a438 Merge pull request #120 from rubocop/support-contextual
  • 0faa678 Support AutoCorrect: contextual option for LSP
  • 2051d01 Merge pull request #119 from rubocop/pirj-patch-1
  • 2267144 Better cop rename examples
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop-factory_bot](https://github.com/rubocop/rubocop-factory_bot) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-factory_bot/releases)
- [Changelog](https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-factory_bot@v2.22.0...v2.26.0)

---
updated-dependencies:
- dependency-name: rubocop-factory_bot
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 12, 2024
@dependabot dependabot bot requested a review from bastelfreak as a code owner June 12, 2024 13:24
@dependabot dependabot bot added the ruby Pull requests that update Ruby code label Jun 12, 2024
@dependabot dependabot bot requested a review from a team as a code owner June 12, 2024 13:24
Copy link
Author

dependabot bot commented on behalf of github Jun 20, 2024

Looks like rubocop-factory_bot is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Jun 20, 2024
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-factory_bot-gte-0 branch June 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants