fixes #228 better check for puppetcerts when running multimaster to prevent infinite hang #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aster to prevent infinite hang
anthonysomerset
requested review from
Xtigyro,
davidphay and
ldaneliukas
as code owners
Xtigyro
suggested changes
May 9, 2024
There was a problem hiding this comment.
@anthonysomerset Would you mind please resolving the conflicts - bumping further the chart version and running the Unit tests will be needed too.
Xtigyro
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #228
basically instead of looking for a static file puppet.pem we use find to search for a file that has puppet and ends .pem
this allows for the potential that Kubernetes clusters where certs might get generated with fully qualified paths
Find has to be used because you can't do wildcard file tests in bash so you have to use find in a subshell to search for the wildcard then return a count of files