Add helpers to wrap eventmachine use #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had some utf-8 spaces, which were causing mild fights with emacs as it wanted to add a magic comment.
| @@ -81,6 +81,40 @@ def get_pcp_broker_status(host) | |||
| end | |||
| end | |||
|
|
|||
| # Start an eventmachine reactor in a thread | |||
| # @return Thread object where the EM reactor should be running | |||
| def start_eventmachine_thread | |||
There was a problem hiding this comment.
Another method name like get_eventmachine_thread would inform readers that this method returns a thread. Then again it wouldn't inform them that that starts a thread...
There was a problem hiding this comment.
Yeah, I think 'start' or 'create' are the verbs that fit here, if we were pulling from a pool of threads then I think "get" would fit, but with EventMachine it's a singleton.
Here we extract the common start/stop eventmachine thread blocks to methods, so we can add some additional debugging to them.
Here we beef up the newly-extracted {start,stop}_eventmachine_thread
helpers to give us more insight as to what's going on with eventmachine.
It should help in diagnosing this class of failing test:
* On each agent, test that a 2nd association has occurred
RuntimeError: An Eventmachine reactor needs to be running
/var/lib/jenkins/workspace/platform_pxp-agent_intn-van-sys_stable/SLAVE_LABEL/beaker/TEST_TARGET/windows2012r2-64a/acceptance/tests/reconnect_after_broker_unavailable.rb:25
/var/lib/jenkins/workspace/platform_pxp-agent_intn-van-sys_stable/SLAVE_LABEL/beaker/TEST_TARGET/windows2012r2-64a/acceptance/tests/reconnect_after_broker_unavailable.rb:24
/var/lib/jenkins/workspace/platform_pxp-agent_intn-van-sys_stable/SLAVE_LABEL/beaker/TEST_TARGET/windows2012r2-64a/acceptance/tests/reconnect_after_broker_unavailable.rb:24
/var/lib/jenkins/workspace/platform_pxp-agent_intn-van-sys_stable/SLAVE_LABEL/beaker/TEST_TARGET/windows2012r2-64a/acceptance/tests/reconnect_after_broker_unavailable.rb:24
/var/lib/jenkins/workspace/platform_pxp-agent_intn-van-sys_stable/SLAVE_LABEL/beaker/TEST_TARGET/windows2012r2-64a/acceptance/tests/reconnect_after_broker_unavailable.rb:23
/usr/local/rvm/gems/ruby-2.1.1/gems/beaker-2.34.0/bin/beaker:6
/usr/local/rvm/gems/ruby-2.1.1/bin/ruby_executable_hooks:15
/usr/local/rvm/gems/ruby-2.1.1/bin/ruby_executable_hooks:15
richardc
force-pushed
the
wrap_em_use
branch
from
adeb604
to
38f7239
Compare
james-stocks
pushed a commit
that referenced
this pull request
Feb 23, 2016
Add helpers to wrap eventmachine use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we extract methods to start and stop the eventmachine thread that ruby-pcp-client needs, then add some additional exception handling and state checks to investigate current issues with non-running reactors.