(maint) Refactor Configuration #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
parisiale
commented
Apr 11, 2016
parisiale
commented
- README change: required leatherman version
- Style changes
- Remove HW alias from Configuration header
- Use boost::format for error messages, to make things clearer
- Remove duplicated code from Configuration functions
added 5 commits
April 11, 2016 19:47
| switch (opt_idx->ptr->type) { | ||
| case Integer: | ||
| check_key_type(key, "Integer", lth_jc::DataType::Int); | ||
| HW::SetFlag<int>(key, config_json.get<int>(key)); |
There was a problem hiding this comment.
should this use HorseWhisperer rather than HW?
There was a problem hiding this comment.
no; the "HW" alias is defined above
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.