(maint) Make tests compatible with leatherman 0.4 and 0.5 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisiale
changed the title
Removing the Catch's applyCommandLine() and passing CLI arguments directly to the Session::run() function; note that setting ConfigData showDurations to "Always" works in the same way as it's not changed by our CI pipeline via CLI.
| @@ -16,28 +16,28 @@ | |||
| #include <leatherman/logging/logging.hpp> | |||
| #endif | |||
|
|
|||
| int main(int argc, const char** argv) { | |||
| int main(int argc, char** argv) { | |||
There was a problem hiding this comment.
Different signature in Catch 1.4.0.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the Catch's applyCommandLine() and passing CLI arguments
directly to the Session::run() function; note that setting ConfigData
showDurations to "Always" works in the same way as it's not changed by
our CI pipeline via CLI.