(maint) Allow use of beaker 3.x in acceptance tests #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
|
If you want this everywhere, you should target it at LTS-1.7. Where does it apply? |
ScottGarman
changed the title
|
Marking this do not merge until some unexpected issues with beaker are sorted out. |
|
@MikaelSmith btw, this is needed for Ubuntu 16.10 support, which is targeted for release in 1.9.0. Not sure if we want it everywhere atm. |
|
Ok, then master seems sufficient. |
ScottGarman
changed the title
|
Ok, the beaker-facter gem has been updated to resolve the issues we were seeing. This PR is now safe to merge. |
|
This PR is blocked again until puppetlabs/facter#1495 is addressed. |
ScottGarman
changed the title
ScottGarman
changed the title
This updates the Gemspec to allow the use of beaker 3.x, which is needed to include support for new platforms (Ubuntu 16.10 in particular).
ScottGarman
force-pushed
the
rev-beaker-acceptance
branch
from
7a0aa22
to
5791c5f
Compare
|
I've rebased this PR and targeted it at stable for inclusion in puppet-agent 1.9.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Gemspec to allow the use of beaker 3.x, which
is needed to include support for new platforms (Ubuntu 16.10
in particular).