(maint) Log version and level at startup #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
|
Default output now is |
MikaelSmith
force-pushed
the
log-starting
branch
from
d8ed9a2
to
3c75020
Compare
mruzicka
suggested changes
Jun 29, 2017
exe/main.cc
Outdated
| LOG_DEBUG("pxp-agent logging has been initialized"); | ||
| std::string version, loglevel; | ||
| std::tie(version, loglevel) = Configuration::Instance().setupLogging(); | ||
| LOG_INFO("pxp-agent {1} started at {2} level", version, loglevel); |
There was a problem hiding this comment.
I'd suggest returning only the log level from the Configuration::Instance().setupLogging() method and using the PXP_AGENT_VERSION here directly. The rationale being that the PXP_AGENT_VERSION define is relevant to all of the pxp-agent code not just logging, so it seems inappropriate to return its value from the logging setup function. Moreover by simplifying the setupLogging()'s return value we'll be able to avoid having to pack/unpack the two values to/from the std::pair.
lib/src/configuration.cc
Outdated
| if (!log_on_stdout) { | ||
| // Configure platform-specific things for file logging | ||
| // NB: we do that after setting up lth_log in order to log in | ||
| // case of failure | ||
| configure_platform_file_logging(); | ||
| } | ||
|
|
||
| return std::make_pair(PXP_AGENT_VERSION, loglevel); |
There was a problem hiding this comment.
As suggested above: Return just the log level from the method.
Logs pxp-agent version and configured log level as soon as logging is configured. Clarifies when versions change in logging, which makes debugging issues easier.
MikaelSmith
force-pushed
the
log-starting
branch
from
3c75020
to
10fa306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs pxp-agent version and configured log level as soon as logging is
configured. Clarifies when versions change in logging, which makes
debugging issues easier.