Skip to content

Commit

Permalink
Increase default pool_size to 4
Browse files Browse the repository at this point in the history
Solves #1038.  pool_size was added as an optional setting
a while ago and people have been using it successfully
in the wild.  This commit increases the default to 4
which seems like a generally useful improvement.
  • Loading branch information
npwalker committed Apr 15, 2020
1 parent 5029fd4 commit f9f801b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/r10k/puppetfile.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Puppetfile

include R10K::Settings::Mixin

def_setting_attr :pool_size, 1
def_setting_attr :pool_size, 4

include R10K::Logging

Expand Down
4 changes: 2 additions & 2 deletions lib/r10k/settings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ def self.global_settings
}),

Definition.new(:pool_size, {
:desc => "The amount of threads used to concurrently install modules. The default value is 1: install one module at a time.",
:default => 1,
:desc => "The amount of threads used to concurrently install modules. The default value is 4: install four modules at a time.",
:default => 4,
:validate => lambda do |value|
if !value.is_a?(Integer)
raise ArgumentError, "The pool_size setting should be an integer, not a #{value.class}"
Expand Down

0 comments on commit f9f801b

Please sign in to comment.