(maint) Remove second non_module_object from test #1057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After increasing the default pool_size, a bug surfaced when attempting to install multiple objects from the same git source. We attempt to cache both objects, but the second attempt fails because we try to clone to the same destination. We don't think this is common behavior and this test does not need two objects to test what it's testing.
Magisus
approved these changes
Apr 30, 2020
|
I've filed #1058 about the bug this uncovered. We can revisit this decision if there are any comments on that issue that this is a common workflow. |
|
Confirmed that this passes now. |
|
I'd like to block this until we get feedback on the associated issue regarding the scope of those affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After increasing the default pool_size, a bug surfaced when attempting to
install multiple objects from the same git source. We attempt to cache both
objects, but the second attempt fails because we try to clone to the same
destination. We don't think this is common behavior and this test does not need
two objects to test what it's testing.
Please add all notable changes to the "Unreleased" section of the CHANGELOG.