Revert increase in default pool size #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinstoller Can you add some info to the commit message (maybe linking to the issue) about why we're doing this? |
mwaggett
reviewed
May 5, 2020
|
We should also revert the changelog entry: b340894 |
This reverts commit f9f801b.
justinstoller
force-pushed
the
maint-revert-defaultpoolsize
branch
from
9a3d295 to
31ea9ad
Compare
justinstoller
changed the title
|
The changelog entry doesn't revert, there's been additional changes since then formatting the changelog line. I've added a new commit removing it. |
Magisus
previously approved these changes
May 5, 2020
|
@justinstoller if you update the commit message, I will merge |
After updating the default pool_size, a race condition was found when initializing our local git cache. See puppetlabs#1058 for the issue in detail. When attempting a fix we realized that there were multiple copies of the code to iterate over modules to manage. See puppetlabs#1059 for a first attempt at this problem and discussion. In order to meet our current timelines, the default will need to reverted until we can fix this issue properly. Hence this commit and a55536c. This commit was necessary because the CHANGELOG has been refactored since the commit referencing the default was added.
justinstoller
force-pushed
the
maint-revert-defaultpoolsize
branch
from
31ea9ad to
007d37b
Compare
|
Updated the commit message and put it in the PR description. |
mwaggett
approved these changes
May 6, 2020
Magisus
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the default pool_size, a race condition was
found when initializing our local git cache. See
#1058 for the issue in detail.
When attempting a fix we realized that there were multiple copies of the
code to iterate over modules to manage. See
#1059 for a first attempt at this
problem and discussion.
In order to meet our current timelines, the default will need to reverted
until we can fix this issue properly. Hence this commit and a55536c.
This commit was necessary because the CHANGELOG has been refactored since
the commit referencing the default was added.