(maint) Extract Puppetfile accept logic to ContentSynchronizer #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaggett
reviewed
Apr 23, 2021
The Puppetfile internally contains logic to sync modules either concurrently or serially depending on pool size. This would be valuable to other means of attaching modules to an environment. The first step in doing so is to extract the sync code into a helper module called R10K::ContentSynchronizer.
justinstoller
force-pushed
the
module-synchronizer
branch
from
e64f406 to
06ae1c4
Compare
mwaggett
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Puppetfile internally contains logic to sync modules either
concurrently or serially depending on pool size. This would be valuable
to other means of attaching modules to an environment. The first step in
doing so is to extract the sync code into a helper module called
R10K::ContentSynchronizer.
Please add all notable changes to the "Unreleased" section of the CHANGELOG in the format: