(RK-378) Restore access to the environment name from the Puppetfile #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, accessing '@librarian.basedir' from the Puppetfile was removed in a non major version. This commit restores the '@librarian.basedir' functionality with a deprecation warning.
Prior to this commit, there was not an easy way to access the environment name from the Puppetfile. This commit adds 'environment_name' to the Puppetfile DSL to allow users to access the environment name if it is provided. The common way to access that is '@librarian.environment_name' which will be a string containing the name of the environment or `nil` if there was no environment provided.
jarretlavallee
force-pushed
the
rk_378-restore_librarian_basedir
branch
from
3c684c4 to
7c9b582
Compare
Magisus
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the
basedirgetter in the Puppetfile DSL with a deprecation warning and adds a new 'environment_name' getter that can be used to get the name of the environment.