(maint) Emit more debug output when mod sync fails #1334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharpie
requested changes
Mar 15, 2023
| updated = mod.sync | ||
| updated_modules << mod.name if updated | ||
| rescue Exception => e | ||
| logger.debug _("Module %{mod_name} failed to synchronize due to %{message}") % {mod_name: mod.name, message: e.message} |
There was a problem hiding this comment.
Looks good, but this should be at error or warn level so that the information is always visible without having to re-run with debug enabled (difficult to do in Code Manager, and doubly so with ephemeral environments like Impact Analysis branches).
There was a problem hiding this comment.
error level seems the most appropriate as the sort of occurrence causes r10k to exit with a non-0 status, which is fatal to the code deployment process.
|
This PR has been marked stale because it has had no activity for 60 days. If you are still interested in getting this merged, please comment and we'll try to move it forward. Otherwise, it will be closed in 7 days. |
|
Couldn't reopen this PR so I created #1347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add all notable changes to the "Unreleased" section of the CHANGELOG in the format: