-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Ruby 3.1 #1402
Require Ruby 3.1 #1402
Conversation
3b1b107
to
cceff7b
Compare
This allows us to use the latest minitar and forge_ruby dependencies.
I've been looking into releasing R10K with this PR and there's one question I have. Our puppet-agent and PDK packages support Ruby 3.1 but have not been updated to vendor or even support in code Internally, we've been trying to consolidate duplicated gems between our vendored r10k package and the puppet-runtime. However, this would only work if we definitely ship r10k with dependency versions that may conflict with newer agent and pdk builds. |
I would be much more comfortable releasing this if we keep 3.1 as a requirement and open up the dependencies to 0.9+ or 1.x compatibility with minitar (and deps that depend on minitar) and change the code to use whichever constants are available. That way consumers can still load Puppet & R10K as libraries in the same process and users can install the r10k gem without having to install multiple copies of minitar and puppet_forge, but when the pdk and/or the puppet-agent upgrades to using newer minitar we will automatically start using it. |
Hi!
This is only relevant for pdk I think? the I just checked puppet-agent-8.10.0-1.el8.x86_64.rpm and it doesn't contain minitar. it's maybe only vendored on windows, but I doubt that r10k works on Windows? And that leaves pdk. PDK pins to I would say this is actually a benefit for Perforce. The new r10k isn't rolled out to all users at the same time, it's basically split into pdk vs non-pdk people. And the group that you officially support, the pdk people, will get it later after it's more tested. I don't think it's worth the time to implement support for minitar 0.X and 1.X and I certainly do not have the time. If someone wants to do this, I don't mind. But I think it makes more sense to work on moving forward . Let's drop minitar 0.x in r10k, then in pdk, beaker and puppet-modulebuilder. |
Thanks for your input, Tim! I'm finding an answer to the question of how and when we plan to integrate these updates into PE and will move forward with the release process once I hear back. |
I should have an answer for you end of day Wednesday |
Okay, I think this is what we should do: #1408 let me know what you think, Tim. |
@bastelfreak just so we don't lose track of this |
This allows us to use the latest minitar and forge_ruby dependencies.
Replaces: