Add a transitive test property #35
Draft
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minimal reproducer that's essentially A ~> B ~> C. The that_subscribes_to matcher shows that this is equal to A ~> C but in practice Puppet doesn't work that way. The service is not restarted if the file is modified. I don't know what is the expected behavior here, but it does mean that today it's not possible to test for real world behavior.
|
Are these the only changes required to enable this? |
|
No, please see the original discussion in rodjek#821. Right now this is here just to show that it's broken. This may look green, but that's just because the tests didn't run. I still don't know what the expected behavior is: either Puppet should be fixed or rspec-puppet should reflect what Puppet actually does. |
|
Understood. Thanks for clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal reproducer that's essentially A ~> B ~> C. The that_subscribes_to matcher shows that this is equal to A ~> C but in practice Puppet doesn't work that way. The service is not restarted if the file is modified.
I don't know what is the expected behavior here, but it does mean that today it's not possible to test for real world behavior.
It was first opened as rodjek#821 but that repo was forked. Then I opened #29 but it was closed due to a change of the default branch so here is attempt number 3.