Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle string credentials #369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle string credentials #369

wants to merge 1 commit into from

Conversation

Clebam
Copy link
Contributor

@Clebam Clebam commented Feb 17, 2025

Summary

Ensure Sentive[String] also accept String

(Concerns SecureString - though SecureString is never used in any resource - and PSCredential)

Additional Context

Fix this issue : #367

Related Issues (if any)

Is a requirement for : puppetlabs/Puppet.Dsc#306

#367

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@Clebam Clebam requested a review from a team as a code owner February 17, 2025 08:39
@Clebam
Copy link
Contributor Author

Clebam commented Feb 17, 2025 •
edited
Loading

Hi, unit test show an issue but I can't figure out what it is.

I lack knowledge with specs.

If anyone could help

edit:
this seems to have saved the day 😁

        allow(Puppet::Pops::Types::PSensitiveType::Sensitive).to receive(:===).with(foo_password).and_return(true)

@Clebam Clebam force-pushed the Handle-string-credentials branch from 0c8afa1 to 845eaf1 Compare February 17, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Clebam