Throw on stop in case of unsuccesfull shutdown

puppetlabs · Dec 10, 2021 · ebb6963 · ebb6963
1 parent 60720a7
commit ebb6963
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/puppetlabs/trapperkeeper/internal.clj b/src/puppetlabs/trapperkeeper/internal.clj
@@ -616,8 +616,12 @@
         (inc-restart-counter! this)
         this)
       (a/stop [this]
-        (shutdown! app-context)
-        this)
+        (if-let [errors (not-empty (shutdown! app-context))]
+          (let [msg (i18n/trs "Error during app shutdown!")
+                e (ex-info msg {:errors errors})]
+            (log/error e msg)
+            (throw e))
+          this))
       (a/restart [this]
         (try
           (run-lifecycle-fns app-context s/stop "stop" (reverse ordered-services))